Closed
Bug 1551083
Opened 6 years ago
Closed 6 years ago
Enable bugprone-move-forwarding-reference and fix the issues
Categories
(Developer Infrastructure :: Source Code Analysis, task, P3)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox68 fixed)
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
https://clang.llvm.org/extra/clang-tidy/checks/bugprone-move-forwarding-reference.html
forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead
We have only two references in the code.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
Depends on D30816
|
||
Updated•6 years ago
|
Attachment #9064315 -
Attachment description: Bug 1551083 - Fix two bugprone-move-forwarding-reference defects r?erahm → Bug 1551083 - Fix a bugprone-move-forwarding-reference defect in ProfileBufferEntry r?erahm
|
|
Assignee | |
Updated•6 years ago
|
Type: defect → task
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/030c742c25d5
Enable bugprone-move-forwarding-reference r=andi
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a15e072aac3f
Fix a bugprone-move-forwarding-reference defect in ProfileBufferEntry r=erahm
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/030c742c25d5
https://hg.mozilla.org/mozilla-central/rev/a15e072aac3f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•